add test for dupe exposures and dupe model/exposure name

core/dbt/parser/schemas.py

@@ -586,7 +586,7 @@ def parse_file(self, block: FileBlock) -> None:
  elif key == NodeType.Analysis:
  parser = AnalysisPatchParser(self, yaml_block, plural)
  elif key == NodeType.Exposure:
- # handle exposures seperately, but they are
+ # handle exposures separately, but they are
  # technically still "documentable"
  continue
  else:

test/integration/025_duplicate_model_test/models-exposure-dupes/schema.yml

@@ -0,0 +1,10 @@
+version: 2
+exposures:
+ - name: something
+ type: dashboard
+ owner:
+ email: [email protected]
+ - name: something
+ type: dashboard
+ owner:
+ email: [email protected]

test/integration/025_duplicate_model_test/models-naming-dupes/schema.yml

@@ -0,0 +1,9 @@
+version: 2
+models:
+ - name: something
+ description: This table has basic information about orders, as well as some derived facts based on payments
+exposures:
+ - name: something
+ type: dashboard
+ owner:
+ email: [email protected]

test/integration/025_duplicate_model_test/test_duplicate_exposure.py

@@ -0,0 +1,24 @@
+from dbt.exceptions import CompilationException
+from test.integration.base import DBTIntegrationTest, use_profile
+
+
+class TestDuplicateExposure(DBTIntegrationTest):
+
+ @property
+ def schema(self):
+ return "duplicate_exposure_025"
+
+ @property
+ def models(self):
+ return "models-exposure-dupes"
+
+ @use_profile("postgres")
+ def test_postgres_duplicate_exposure(self):
+ # message = "dbt found two resources with the name"
+ try:
+ self.run_dbt(["compile"])
+ self.assertTrue(False, "dbt did not throw for duplicate exposures")
+ except CompilationException as e:
+ pass
+ # self.assertTrue(message in str(
+ # e), "dbt did not throw the correct error message")

test/integration/025_duplicate_model_test/test_duplicate_model.py

@@ -12,34 +12,15 @@ def schema(self):
  def models(self):
  return "models-1"
 
- @property
- def profile_config(self):
- return {
- "test": {
- "outputs": {
- "dev": {
- "type": "postgres",
- "threads": 1,
- "host": self.database_host,
- "port": 5432,
- "user": "root",
- "pass": "password",
- "dbname": "dbt",
- "schema": self.unique_schema()
- },
- },
- "target": "dev"
- }
- }
-
  @use_profile("postgres")
  def test_postgres_duplicate_model_enabled(self):
  message = "dbt found two resources with the name"
  try:
  self.run_dbt(["run"])
  self.assertTrue(False, "dbt did not throw for duplicate models")
  except CompilationException as e:
- self.assertTrue(message in str(e), "dbt did not throw the correct error message")
+ self.assertTrue(message in str(
+ e), "dbt did not throw the correct error message")
 
 
 class TestDuplicateModelDisabled(DBTIntegrationTest):
@@ -52,26 +33,6 @@ def schema(self):
  def models(self):
  return "models-2"
 
- @property
- def profile_config(self):
- return {
- "test": {
- "outputs": {
- "dev": {
- "type": "postgres",
- "threads": 1,
- "host": self.database_host,
- "port": 5432,
- "user": "root",
- "pass": "password",
- "dbname": "dbt",
- "schema": self.unique_schema()
- },
- },
- "target": "dev"
- }
- }
-
  @use_profile("postgres")
  def test_postgres_duplicate_model_disabled(self):
  try:
@@ -124,7 +85,8 @@ def test_postgres_duplicate_model_enabled_across_packages(self):
  self.run_dbt(["run"])
  self.assertTrue(False, "dbt did not throw for duplicate models")
  except CompilationException as e:
- self.assertTrue(message in str(e), "dbt did not throw the correct error message")
+ self.assertTrue(message in str(
+ e), "dbt did not throw the correct error message")
 
 
 class TestDuplicateModelDisabledAcrossPackages(DBTIntegrationTest):

test/integration/025_duplicate_model_test/test_duplicate_resource.py

@@ -0,0 +1,21 @@
+from dbt.exceptions import CompilationException
+from test.integration.base import DBTIntegrationTest, use_profile
+
+
+class TestDuplicateSchemaResource(DBTIntegrationTest):
+
+ @property
+ def schema(self):
+ return "duplicate_resource_025"
+
+ @property
+ def models(self):
+ return "models-naming-dupes-1"
+
+ @use_profile("postgres")
+ def test_postgres_duplicate_model_and_exposure(self):
+ try:
+ self.run_dbt(["compile"])
+ except CompilationException:
+ self.fail("Compilation Exception raised on model and "
+ "exposure with the same name")

test/integration/025_duplicate_model_test/test_duplicate_source.py

@@ -12,31 +12,12 @@ def schema(self):
  def models(self):
  return "models-source-dupes"
 
- @property
- def profile_config(self):
- return {
- "test": {
- "outputs": {
- "dev": {
- "type": "postgres",
- "threads": 1,
- "host": self.database_host,
- "port": 5432,
- "user": "root",
- "pass": "password",
- "dbname": "dbt",
- "schema": self.unique_schema()
- },
- },
- "target": "dev"
- }
- }
-
  @use_profile("postgres")
- def test_postgres_duplicate_model_enabled(self):
+ def test_postgres_duplicate_source_enabled(self):
  message = "dbt found two resources with the name"
  try:
  self.run_dbt(["compile"])
  self.assertTrue(False, "dbt did not throw for duplicate sources")
  except CompilationException as e:
- self.assertTrue(message in str(e), "dbt did not throw the correct error message")
+ self.assertTrue(message in str(
+ e), "dbt did not throw the correct error message")

test/unit/test_contracts_graph_unparsed.py

@@ -579,7 +579,6 @@ class TestUnparsedExposure(ContractTestCase):
 
  def get_ok_dict(self):
  return {
- 'yaml_key': 'exposures',
  'name': 'my_exposure',
  'type': 'dashboard',
  'owner': {
@@ -592,22 +591,17 @@ def get_ok_dict(self):
  'ref("my_model")',
  'source("raw", "source_table")',
  ],
- 'original_file_path': '/some/fake/path',
- 'package_name': 'test'
  }
 
  def test_ok(self):
  exposure = self.ContractType(
- yaml_key='exposures',
  name='my_exposure',
  type=ExposureType.Dashboard,
  owner=ExposureOwner(email='[email protected]'),
  maturity=MaturityType.Medium,
  url='https://example.com/dashboards/1',
  description='A exposure',
  depends_on=['ref("my_model")', 'source("raw", "source_table")'],
- original_file_path='/some/fake/path',
- package_name='test'
  )
  dct = self.get_ok_dict()
  self.assert_symmetric(exposure, dct)