Fix DepsNotifyUpdatesAvailable logging event (#7262)

dbt-labs · Apr 5, 2023 · d5ebbdc · d5ebbdc
1 parent 6a4c3eb
commit d5ebbdc
Show file tree

Hide file tree

Showing 4 changed files with 816 additions and 823 deletions.
diff --git a/core/dbt/events/types.proto b/core/dbt/events/types.proto
@@ -57,11 +57,6 @@ message ReferenceKeyMsg {
  string identifier = 3;
 }
 
-// ListOfStrings
-message ListOfStrings {
- repeated string value = 1;
-}
-
 // GenericMessage, used for deserializing only
 message GenericMessage {
  EventInfo info = 1;
@@ -1301,7 +1296,7 @@ message DepsListSubdirectoryMsg {
 
 // M019
 message DepsNotifyUpdatesAvailable {
- ListOfStrings packages = 1;
+ repeated string packages = 1;
 }
 
 message DepsNotifyUpdatesAvailableMsg {

diff --git a/core/dbt/events/types.py b/core/dbt/events/types.py
@@ -1230,7 +1230,7 @@ def code(self):
  return "M019"
 
  def message(self) -> str:
- return f"Updates available for packages: {self.packages.value} \
+ return f"Updates available for packages: {self.packages} \
  \nUpdate your versions in packages.yml, then run dbt deps"
 
 

diff --git a/core/dbt/events/types_pb2.py b/core/dbt/events/types_pb2.py
diff --git a/tests/unit/test_events.py b/tests/unit/test_events.py
@@ -242,7 +242,7 @@ def test_event_codes(self):
  types.DepsUpdateAvailable(version_latest=""),
  types.DepsUpToDate(),
  types.DepsListSubdirectory(subdirectory=""),
- types.DepsNotifyUpdatesAvailable(packages=[]),
+ types.DepsNotifyUpdatesAvailable(packages=["my_pkg", "other_pkg"]),
  types.RetryExternalCall(attempt=0, max=0),
  types.RecordRetryException(exc=""),
  types.RegistryIndexProgressGETRequest(url=""),