Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to using flake8 in CI instead of pep8 #1333

Closed
beckjake opened this issue Mar 4, 2019 · 0 comments · Fixed by #1361
Closed

Migrate to using flake8 in CI instead of pep8 #1333

beckjake opened this issue Mar 4, 2019 · 0 comments · Fixed by #1361

Comments

@beckjake
Copy link
Contributor

beckjake commented Mar 4, 2019

Feature

dbt should use flake8 during CI instead of pep8.

Feature description

Flake8 is pycodestyle (formerly pep8), pyflakes, and a mccabe complexity checker. We should look into migrating to it for CI, it finds stuff that just pycodestyle misses like unused imports and undefined/unused variable names, without being too noisy.

Who will this benefit?

It means I will write less bugs, so really everyone should be happy about this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/archive blocks dbt-labs/dbt-core
1 participant
@beckjake