Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Wilt Chamberlain] Change snapshot --models flag to --select #1517

Closed
drewbanin opened this issue Jun 6, 2019 · 3 comments
Closed

[Wilt Chamberlain] Change snapshot --models flag to --select #1517

drewbanin opened this issue Jun 6, 2019 · 3 comments
Milestone
Wilt Chamberlain

Comments

@drewbanin
Copy link
Contributor

Feature

Feature description

The functionality of the --models flag to the snapshot command is perfect. We should just rename it to --select, as this flag selects snapshots, not models.

Who will this benefit?

Consistency!
@drewbanin drewbanin added this to the Wilt Chamberlain milestone Jun 6, 2019
@drewbanin drewbanin changed the title [Wilt Chamberlain] Change snapshot --models flaf to --select [Wilt Chamberlain] Change snapshot --models flag to --select Jun 6, 2019
@beckjake
Copy link
Contributor

beckjake commented Jun 7, 2019

Should this be on both dbt archive and dbt snapshot, or just snapshot?

@drewbanin
Copy link
Contributor Author

I think just dbt snapshot, right? We should probably leave dbt archive as is, though i will add: it's very ok if it makes more sense to change it for both!

beckjake added a commit that referenced this issue Jun 12, 2019
@beckjake
Merge pull request #1520 from fishtown-analytics/feature/rename-model…
a554b38 
…s-to-select

for snapshots, make the argument "--select", not "--models" (#1517)
@beckjake
Copy link
Contributor

Fixed in #1520

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Wilt Chamberlain
Development

No branches or pull requests
2 participants
@beckjake @drewbanin