Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static checks aren't defined in configs #2926

Closed
max-sixty opened this issue Dec 2, 2020 · 2 comments
Closed

Static checks aren't defined in configs #2926

max-sixty opened this issue Dec 2, 2020 · 2 comments
Labels
bug Something isn't working good_first_issue Straightforward + self-contained changes, good for new contributors! stale Issues that have gone stale

Comments

@max-sixty
Copy link
Contributor

Describe the bug

Ref #2908 (comment) & #2908 (comment)

Currently running mypy . & flake8 . returns enough errors to overflow my terminal. It sounds like that's because the ignores & excludes are defined in the tox file, rather than in python config files, like setup.cfg / pyproject.toml / etc.

The tox file isn't picked up by editors, or by anyone running these tools in the standard way.

@max-sixty max-sixty added bug Something isn't working triage labels Dec 2, 2020
@jtcohen6 jtcohen6 added good_first_issue Straightforward + self-contained changes, good for new contributors! and removed triage labels Dec 2, 2020
@jtcohen6
Copy link
Contributor

jtcohen6 commented Dec 2, 2020

Good points @max-sixty. We use tox as the basis for all our testing via via make, CI, and dev shorthand (scripts/dtr.py).

That said, I'm in favor of moving these configs down a level so that folks who run mypy or flake8 directly will see the same errors.

@github-actions
Copy link
Contributor

This issue has been marked as Stale because it has been open for 180 days with no activity. If you would like the issue to remain open, please remove the stale label or comment on the issue, or it will be closed in 7 days.

@github-actions github-actions bot added the stale Issues that have gone stale label Oct 28, 2021
@github-actions github-actions bot closed this as completed Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good_first_issue Straightforward + self-contained changes, good for new contributors! stale Issues that have gone stale
Projects
None yet
Development

No branches or pull requests

2 participants