Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Put macros into the flat "graph" #314

Closed
cmcarthur opened this issue Mar 3, 2017 · 1 comment
Closed

Put macros into the flat "graph" #314

cmcarthur opened this issue Mar 3, 2017 · 1 comment
Assignees
@cmcarthur
Labels
enhancement New feature or request
Milestone
Dependency Graph ...

Comments

@cmcarthur
Copy link
Member

Macros don't belong in the actual "graph", but they belong in the state file. Move them there, then remove the DBTSource code that loads Macros.

As we move in this direction it's going to make more and more sense for the flat representation of all the nodes to look like:

{
  macros: [... all macros ...],
  nodes: [... all models, tests, operations ...]
}
@cmcarthur cmcarthur self-assigned this Mar 3, 2017
@cmcarthur cmcarthur added the enhancement New feature or request label Mar 3, 2017
@drewbanin
Copy link
Contributor

💯

@jthandy jthandy closed this as completed Mar 17, 2017
yu-iskw pushed a commit to yu-iskw/dbt that referenced this issue Aug 17, 2021
@clrcrl @jtcohen6 @ChristopheDuong
0.7.0 into main (dbt-labs#372)
a729044 
* Tidy up changelog

* Add 0.7.0 entry to changelog

* Add order_by argument to get_column_values (dbt-labs#349)

* Add slugify macro to utils, use in pivot macro (dbt-labs#314)

* 0.20.0 compatibility (dbt-labs#371)

* Explicitly redefine Redshift -> default

* Upgrade generic tests

* Rm namespaces macro. New dispatch syntax

* Run tests with 0.20.0rc1

* Update changelog, readme

Co-authored-by: Jeremy Cohen <[email protected]>

* Simplify concat (dbt-labs#373)

* Postgres also have an alternative concat binary operation (dbt-labs#296)

* Update default implementation of concat macro

Co-authored-by: Christophe Duong <[email protected]>

Co-authored-by: Jeremy Cohen <[email protected]>
Co-authored-by: Christophe Duong <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cmcarthur cmcarthur

Labels
enhancement New feature or request
Projects
None yet
Milestone
Dependency Graph Improvements
Development

No branches or pull requests
3 participants
@cmcarthur @drewbanin @jthandy