-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate run_results.json even when no nodes are selected #3313
Labels
Comments
4 tasks
@panasenco I buy it! Thanks so much for opening the issue, and for laying out your rationale so clearly. It looks like this was a super simple change, too. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the feature
I'd like the file
target/run_results.json
to be generated with an empty results list even when the selector selected no nodes. The current behavior is to not generate a newrun_results.json
when the selector returned no nodes.A test run with no nodes selected is a legitimate occurence when using the
state:modified
selector.Describe alternatives you've considered
Parsing
dbt test
output for the stringWARNING: Nothing to do. Try checking your model configs and model specification args
. This is a bit hacky and unreliable though.Additional context
Using
dbt test
with thestate:modified
selector in my CI pipeline. I parserun_results,json
to get the test outcome, but that file doesn't get generated when there are no model differences between the branch and PROD. However, the absence ofrun_results.json
could also mean the test process somehow failed...Who will this benefit?
Anyone who depends on
run_results.json
- for example CI pipeline devs.Are you interested in contributing this feature?
I'll browse the source code and give it a shot, but no promises.
The text was updated successfully, but these errors were encountered: