-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Snowflake comments with 0.20-rc2 create a query per comment #3541
Comments
This is not a bug. |
@joshuataylor You're right, the fix in #3149 will slow down column-level Based on what you're seeing anecdotally, how much slower is drastically slower? We could think about reworking this again for v0.21, by checking column metadata, verifying that the user-specified columns exist, and then running a single |
This is awesome, thanks so much, will try it out. It was taking about 2 extra minutes per large table (~100ms I think to run on sf, so take the round trip time maybe an extra 2s end to end?), which is painful when you are charged for the larger warehouse sizes with SF. :-) |
Describe the bug
With 0.19, having comments creates a query like this after the table is built:
Now it does a query per comment, which drastically reduces the speed of building large tables:
This is because of #3149 , I believe this a good fix but can lead to long build times for CI environments.
Steps To Reproduce
Expected behavior
A single alter table.
System information
Which database are you using dbt with?
The output of
dbt --version
:The output of
python --version
:Python 3.8.6
The text was updated successfully, but these errors were encountered: