-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fatal errors are being marked as "warning" when using --log-format json
#3603
Comments
@thisiscab Thanks for opening! I totally agree. More broadly, this is on our radar already ahead of releasing dbt v1.0 later this year: #3359. We want to make sure that we're able to offer structured logging, with reliable log levels, for observation by orchestration tools and monitoring platforms. I see resolving an inconsistency like this one to be squarely in the scope of that effort. |
This will be fixed in v1.0.0, thanks to our ongoing work on structured logging:
|
Describe the bug
When hitting a
RuntimeException
exception, the logs are being marked as "warning"Steps To Reproduce
The easiest way to reproduce this error is to run
dbt --log-format json run
in a project that doesn't contain adbt_project.yml
fileExpected behavior
The level of the log should be increased to either "error", "critical" or "fatal".
Please note that I'm not familiar with log levels that you folks are using, but it's sure shouldn't be marked as "warning".
Screenshots and log output
System information
Which database are you using dbt with?
NOT RELEVANT
The output of
dbt --version
:The operating system you're using:
The output of
python --version
:Additional context
We're using a monitoring platform where we're sending the DBT logs to and allow us to visualize problems, but the logs are incorrectly marked as
warning
and our systems are set up such that warnings are not triggering an alert while other log levels are.When there is a fatal error, we want to be aware of it and be notified ASAP and currently, there isn't a good way to achieve this due to the current log level of "fatal errors".
The text was updated successfully, but these errors were encountered: