-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wait for postgres docker container to be ready before running commands #3876
Labels
bug
Something isn't working
good_first_issue
Straightforward + self-contained changes, good for new contributors!
Comments
@emmyoop Thanks for opening! Sounds like there's a straightforward fix here, so, I'm all about it :) |
jtcohen6
added
good_first_issue
Straightforward + self-contained changes, good for new contributors!
and removed
triage
labels
Sep 14, 2021
4 tasks
rvacaru
added a commit
to rvacaru/dbt
that referenced
this issue
Sep 17, 2021
4 tasks
rvacaru
added a commit
to rvacaru/dbt
that referenced
this issue
Sep 24, 2021
rvacaru
added a commit
to rvacaru/dbt
that referenced
this issue
Oct 8, 2021
jtcohen6
added a commit
that referenced
this issue
Oct 21, 2021
…#3908) * Fix setup_db.sh by waiting for pg_isready success return. Fixes #3876 * restored noaccess and dbtMixedCase creation and updated changelog and contributing md files * restored root auth commands * restored creation of dbt schema, aparently this is needed even if docker compose also creates it... * pr comments: avoid infinite loop and quote variables * Update changelog Co-authored-by: Jeremy Cohen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
good_first_issue
Straightforward + self-contained changes, good for new contributors!
Describe the bug
When running
make setup-db
during setup, it needs to wait for the database to be running before running commands to get the postgres database in the right state.Steps To Reproduce
Run through the steps in CONTRIBUTING. The first time you run
make setup-db
there will be an error that the server connection closed unexpectedly. If you attempt to runmake integration
the tests will fail as dbtMixedCase database will not exist. Runmake setup-db
again and everything will work and integration tests will run.Expected behavior
Be able to run
make setup-db
a single time and have everything work.Screenshots and log output
If applicable, add screenshots or log output to help explain your problem.
System information
Which database are you using dbt with?
The output of
dbt --version
:The operating system you're using:
The output of
python --version
:Additional context
Wait for
pg_isready
in setup_db.sh should fix this.The text was updated successfully, but these errors were encountered: