-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable deprecation: dispatch-packages #3895
Comments
https://docs.getdbt.com/reference/dbt-jinja-functions/dispatch will also need an update. |
@jtcohen6 Should I rip out the |
@emmyoop I think I prefer leaving it in and raising an explicit exception when it's used explicitly. That feels like the same approach as raising an explicit exception when a list is passed to the second positional argument. At the same time, we should feel very comfortable removing all the code from |
dispatch-packages
Introduced in: v0.19.2
In the last week, raised by: 276 projects (~9% of eligible projects)
Instead of raising a deprecation warning when the user has defined the
packages
arg, or has passed a list instead of a string, we should instead raise a clear error. That error message should point to the same documentation that the deprecation warning message currently doeshttps:/dbt-labs/dbt/blob/96083dcaf51ab7725f1b554891581e1522e32d7d/core/dbt/context/providers.py#L137-L140
Then, we can:
DispatchPackagesDeprecation
from the list of active deprecationsjinja_static.py
— to discuss with @gshankOriginally posted by @jtcohen6 in #2798 (comment)
The text was updated successfully, but these errors were encountered: