-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] Integration tests that move files can fail when run in parallel #4060
Labels
bug
Something isn't working
Comments
A test's lifecycle looks something along the lines of:
Here is an example of a possible solution: https:/dbt-labs/dbt-core/compare/refactor-partial-parsing-tests This solution copies and deletes files in a directory in the temp dir that is not symlinked back to the source code. This is still not ideal, I want to use this opportunity to try out a better approach to protect from ending up in this scenario in the future. |
4 tasks
gshank
added a commit
that referenced
this issue
Oct 15, 2021
gshank
added a commit
that referenced
this issue
Oct 15, 2021
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is there an existing issue for this?
Current Behavior
Tests that move files in order to recreate user behavior modify python source code which can lead to failures when running tests in parallel.
Example of workflow failing: https:/dbt-labs/dbt-core/runs/3887780692?check_suite_focus=true#step:9:1350
Example of test that moves files:
dbt-core/test/integration/068_partial_parsing_tests/test_partial_parsing.py
Lines 26 to 215 in fd7c95d
Expected Behavior
Tests should be able to run in parallel.
Steps To Reproduce
I've been able to reproduce by running test in parallel locally. Something like:
python -m pytest -n12 -m profile_postgres test/integration
Relevant log output
No response
Environment
No response
What database are you using dbt with?
No response
Additional Context
No response
The text was updated successfully, but these errors were encountered: