Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wasted time spent in incorporate_indirect_nodes during node selection #4213

Closed
jtcohen6 opened this issue Nov 5, 2021 · 0 comments · Fixed by #4214
Closed

Wasted time spent in incorporate_indirect_nodes during node selection #4213

jtcohen6 opened this issue Nov 5, 2021 · 0 comments · Fixed by #4214

Comments

@jtcohen6
Copy link
Contributor

jtcohen6 commented Nov 5, 2021

While reviewing #4104, I noticed a lot of wasted time spent in incorporate_indirect_nodes.

Here's 3s spent at runtime in the performance testing project:
Screenshot 2021-11-05 at 08 38 36

This method is frequently unnecessary, especially with the change to the default indirect selection mode in that PR. This method only takes effect when there are nodes selected "indirectly" but not "directly," and we want to incorporate them on the basis of their parents' direct selection.

This one is completely on me: I added this way back in #3235, a change we're mostly turning off by default in v1. I think it should only take a few lines to skip this method when it isn't needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant