Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-18] Add adapter compatibility messaging to dbt --version #4438

Closed
nathaniel-may opened this issue Dec 6, 2021 · 6 comments
Closed

[CT-18] Add adapter compatibility messaging to dbt --version #4438

nathaniel-may opened this issue Dec 6, 2021 · 6 comments
Labels
enhancement New feature or request good_first_issue Straightforward + self-contained changes, good for new contributors! jira
Milestone

Comments

@nathaniel-may
Copy link
Contributor

nathaniel-may commented Dec 6, 2021

Describe the Feature

Now that plugins are not shipped alongside dbt-core, users can have incompatible adapters installed alongside dbt-core. We should tell them this when they run dbt --version and use green / red color to make it clear. Original proposal by @jtcohen6 can be found here in #4434 .

% dbt --version
installed version: 1.0.1
   latest version: 1.0.1

Up to date!

Plugins:
  - snowflake: 1.0.0 — compatible
% dbt --version
installed version: 1.0.1
 latest version: 1.0.1

Up to date!

Plugins:
- snowflake: 0.21.1 — requires update!

To update dbt-snowflake please run:
  pip install dbt-snowflake --upgrade

@nathaniel-may nathaniel-may added enhancement New feature or request triage good_first_issue Straightforward + self-contained changes, good for new contributors! labels Dec 6, 2021
@jtcohen6
Copy link
Contributor

jtcohen6 commented Dec 6, 2021

yes!! you beat me to it :)

@nkyuray
Copy link
Contributor

nkyuray commented Dec 13, 2021

Hi,

I want to work on this, but this will be the first for me. If you give some insights on this issue and help, would be happy to work on this.

@leahwicz
Copy link
Contributor

leahwicz commented Jan 4, 2022

@nkyuray sorry we missed your message! Were you still thinking of working on this?

@leahwicz leahwicz added the jira label Jan 5, 2022
@github-actions github-actions bot changed the title Add adapter compatibility messaging to dbt --version [CT-18] Add adapter compatibility messaging to dbt --version Jan 5, 2022
@nkyuray
Copy link
Contributor

nkyuray commented Jan 7, 2022

Hi @leahwicz, yes absolutely:D

@joellabes
Copy link
Contributor

:portalparrot: from #4582, re:

get[ting] plugin-specific "up to date" / "out of date" checks

We could also look into adding checks for each installed plugin, to see if they have a newer compatible version available—at the teensy cost of a bit more semver logic, and a few additional requests to the PyPi API.

I think that this change would also resolve a nitpick I have with the current phrasing - "compatible" and "out of date" are not necessarily the two states I'd describe, because "Compatible" feels like weirdly non-specific word to reassure me.

If I'm on dbt-core 1.0.1, here's what I think would be useful to see for different variants of dbt-snowflake:

  • 0.21.1: [red] Out of date! (and the existing guidance on how to upgrade)
  • 1.0.0: [yellow] Update available! (and the existing guidance on how to upgrade)
  • 1.0.1: [green] Up to date!

With a PR already in flight, I don't necessarily want to move your cheese @nkyuray - let me know what you think.

I'd also note that not all users install dbt via pip - I really like the idea of making the instructions easy, but it'd be confusing to give pip instructions to someone who installed dbt via Homebrew etc. I'll put that comment on the PR because it's more directly linked to the work already done.

@jtcohen6
Copy link
Contributor

jtcohen6 commented Feb 9, 2022

Closing as resolved by #4565!

@ChenyuLInx I left two small comments at the bottom of that PR, relating to edge cases that I think our current logic may not quite be capturing. Could you take a quick look? If appropriate, we can open a new issue to address those cases with future work

@jtcohen6 jtcohen6 closed this as completed Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good_first_issue Straightforward + self-contained changes, good for new contributors! jira
Projects
None yet
Development

No branches or pull requests

5 participants