-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CT-18] Add adapter compatibility messaging to dbt --version #4438
Comments
yes!! you beat me to it :) |
Hi, I want to work on this, but this will be the first for me. If you give some insights on this issue and help, would be happy to work on this. |
@nkyuray sorry we missed your message! Were you still thinking of working on this? |
Hi @leahwicz, yes absolutely:D |
:portalparrot: from #4582, re:
I think that this change would also resolve a nitpick I have with the current phrasing - "compatible" and "out of date" are not necessarily the two states I'd describe, because "Compatible" feels like weirdly non-specific word to reassure me. If I'm on dbt-core 1.0.1, here's what I think would be useful to see for different variants of dbt-snowflake:
With a PR already in flight, I don't necessarily want to move your cheese @nkyuray - let me know what you think. I'd also note that not all users install dbt via pip - I really like the idea of making the instructions easy, but it'd be confusing to give pip instructions to someone who installed dbt via Homebrew etc. I'll put that comment on the PR because it's more directly linked to the work already done. |
Closing as resolved by #4565! @ChenyuLInx I left two small comments at the bottom of that PR, relating to edge cases that I think our current logic may not quite be capturing. Could you take a quick look? If appropriate, we can open a new issue to address those cases with future work |
Describe the Feature
Now that plugins are not shipped alongside dbt-core, users can have incompatible adapters installed alongside dbt-core. We should tell them this when they run
dbt --version
and use green / red color to make it clear. Original proposal by @jtcohen6 can be found here in #4434 .The text was updated successfully, but these errors were encountered: