-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] Docker plugin latest
images should update with new dbt-core versions
#4756
Comments
I realize the obvious workaround here is just |
I understand from this slack message that this behavior is more or less intentional, but I'm still curious for a bit more context as to why 😄 |
Thanks for opening @alexrosenfeld10. The current intention is definitely to rerelease the |
latest
images should update with new dbt-core versions
@jtcohen6 I may be misunderstanding this, but this still seems not ideal. Take the following scenario:
I'm sure the engineering team has all sorts of automated testing and hopes to not release bugs in patch versions, but inevitably bugs slip in to any software. Might the team consider a different approach to mitigate this issue? Or do you think I'm overly concerned? (again I know I can just install the specific core version and pip install the plugin. More curious about the intention and design choice here, so thanks in advance for entertaining my questions!) |
@alexrosenfeld10 I think your concern is well placed and reasonable! You always have the right to install the exact pinned versions of I'll just say that our team is tremendously committed to limiting the scope of fixes in patch releases after v1.0, and avoiding net-new bugs in patches. When they happen (it's software, it happens), we will drop everything to release a new working patch ASAP. This just happened earlier today: a community member identified a highly specific bug (#4752, net-new in v1.0.2); we estimated that it would affect ~0.5% of projects; we've already merged the fix, and we're planning to push v1.0.3 live very soon. We also used this to prompt internal conversation and reflection on how we would patch the fix differently next time. This is added motivation for our current initiative, overhauling our test suite to better represent That's the commitment we're making to you, as a potential user of the To that end, v1.0.2 fixed a separate dependency error (#4745) that affected 100% of projects. Folks installing That's the rationale underlying So, those are the options available to you:
Does that delineation make sense? (@iknox-fa Does it makes sense to you?) |
@jtcohen6 that all makes sense to me, yes. I think, given the commitments (and the fact that dbt Cloud takes patch updates OOTB) I'll probably just target Thanks 👍 |
@alexrosenfeld10 We should be all set now. Give it a try and feel free to reach out if it gives you any more trouble. |
@iknox-fa seems good to me:
|
@iknox-fa while you're in the docker neighborhood, was wondering if you had thoughts about this: #4784 and / or if it's related to potential bugs in the recent base images? (I realize it's a bit separate, so I'll close this issue, I hope we can continue the docker discussions over there as I'm pretty stuck on this) |
Is there an existing issue for this?
Current Behavior
dbt core 1.0.2 has been released as well as its docker image, ghcr.io/dbt-labs/dbt-core:1.0.2. However, the latest version of the plugin specific docker images don't use the latest dbt core version (well, at least snowflake - I didn't test the others, but i'd imagine it's the same).
Expected Behavior
The "latest" plugin docker images should use the latest version of dbt-core.
Steps To Reproduce
Pretty simple:
Relevant log output
What database are you using dbt with?
No response
Additional Context
https://getdbt.slack.com/archives/CBSQTAPLG/p1645383426339879
The text was updated successfully, but these errors were encountered: