-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CT-1511] A general solution for accessing attributes in the flag object safely #6259
Open
Tracked by
#6706
Labels
tech_debt
Behind-the-scenes changes, with little direct impact on end-user functionality
Comments
github-actions
bot
changed the title
A general solution for accessing attributes in the flag object safely
[CT-1511] A general solution for accessing attributes in the flag object safely
Nov 16, 2022
jtcohen6
added
tech_debt
Behind-the-scenes changes, with little direct impact on end-user functionality
Team:Execution
and removed
enhancement
New feature or request
triage
labels
Nov 16, 2022
Thanks @ChenyuLInx! I added to the list in #5527 |
29 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Issue
Right now in the click cli, we are trying to front load everything in Flags and then trying to use it at the root level CLI function. This makes accessing attributes defined in lower level cli functions possible, but this operation itself is not safe.
For example, right now if we try to run
docs
command with the click cli(python core/dbt/cli/main.py docs
), we will run into errorsince
PROFILES_DIR
is a parameter that is not defined in any of the command underdocs
, it never got set inFlags
.potential Exit Criteria:
The text was updated successfully, but these errors were encountered: