Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-1658] Logging changes break dbt-rpc #6437

Closed
2 tasks done
peterallenwebb opened this issue Dec 13, 2022 · 0 comments · Fixed by #6443
Closed
2 tasks done

[CT-1658] Logging changes break dbt-rpc #6437

peterallenwebb opened this issue Dec 13, 2022 · 0 comments · Fixed by #6443
Assignees
Labels
bug Something isn't working logging

Comments

@peterallenwebb
Copy link
Contributor

peterallenwebb commented Dec 13, 2022

Is this a new bug in dbt-core?

  • I believe this is a new bug in dbt-core
  • I have searched the existing issues, and I could not find an existing issue for this bug

Current Behavior

Due to recent changes, logs are now written to the logbook GLOBAL_LOGGER using the same numeric priority as used for native Python logs, but they are not compatible. Furthermore, the GLOBAL_LOGGER is not written to by default, and dbt-rpc does not do its own log set up. We need to correct both issues so that dbt-core logging behavior with respect to the legacy logbook code remains the same in 1.4 as it was in 1.3.

Expected Behavior

When DBT_ENABLE_LEGACY_LOGGING is true, dbt-core should exhibit the same log output behaviors as it did in 1.3.

Steps To Reproduce

The issue can be seen in the GitHub actions for the dbt-rpc build, which are currently failing.

@peterallenwebb peterallenwebb added bug Something isn't working triage and removed triage labels Dec 13, 2022
@github-actions github-actions bot changed the title Logging changes break dbt-rpc [CT-1658] Logging changes break dbt-rpc Dec 13, 2022
@peterallenwebb peterallenwebb self-assigned this Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working logging
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants