Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-1766] [DX] Review command + param help text in CLI / top-level API #6546

Closed
Tracked by #7162 ...
jtcohen6 opened this issue Jan 8, 2023 · 2 comments · Fixed by #7176
Closed
Tracked by #7162 ...

[CT-1766] [DX] Review command + param help text in CLI / top-level API #6546

jtcohen6 opened this issue Jan 8, 2023 · 2 comments · Fixed by #7176
Assignees
Labels
cli enhancement New feature or request paper_cut A small change that impacts lots of users in their day-to-day python_api Issues related to dbtRunner Python entry point Refinement Maintainer input needed

Comments

@jtcohen6
Copy link
Contributor

jtcohen6 commented Jan 8, 2023

Let's give the "help" text defined below another review from a DX (Developer Experience) lens:

Anything marked TODO is especially in need, but I think all help text deserves another look-over.

This is also our opportunity to remove params / help text that are completely unused or irrelevant. For example, dbt compile --parse-only doesn't do anything, and I don't believe it ever has.

Context

This is what users will see when running dbt --help (invoked as module for now):

$ python3 -m core.dbt.cli.main --help
Usage: python -m core.dbt.cli.main [OPTIONS] COMMAND [ARGS]...

  An ELT tool for managing your SQL transformations and data models. For more
  documentation on these commands, visit: docs.getdbt.com

Options:
  --anonymous-usage-stats / --no-anonymous-usage-stats
                                  Send anonymous usage stats to dbt Labs.
  --cache-selected-only / --no-cache-selected-only
                                  Pre cache database objects relevant to
                                  selected resource only.
  -d, --debug / --no-debug        Display debug logging during dbt execution.
                                  Useful for debugging and making bug reports.

And it's also what they'll see in our auto-generated "API docs."

Screenshot 2023-01-08 at 18 19 28

@jtcohen6 jtcohen6 added enhancement New feature or request Refinement Maintainer input needed paper_cut A small change that impacts lots of users in their day-to-day labels Jan 8, 2023
@github-actions github-actions bot changed the title [DX] Review command + param help text in CLI / top-level API [CT-1766] [DX] Review command + param help text in CLI / top-level API Jan 8, 2023
@jtcohen6 jtcohen6 added python_api Issues related to dbtRunner Python entry point cli labels Jan 8, 2023
@jtcohen6
Copy link
Contributor Author

jtcohen6 commented Mar 1, 2023

@dbeatty10 Let's figure out a sprint where you have capacity to pick this up & drive this forward, between now and mid-April (RC release)

@jtcohen6
Copy link
Contributor Author

Might be nice: using the click-option-group extension to group together related commands in the --help output (and in the codebase).

Not necessary for the scope for this issue, only if inspiration strikes while looking at existing params.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli enhancement New feature or request paper_cut A small change that impacts lots of users in their day-to-day python_api Issues related to dbtRunner Python entry point Refinement Maintainer input needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants