-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CT-1869] Turn --output-keys
into MultiOption
#6676
Labels
Comments
jtcohen6
added
python_api
Issues related to dbtRunner Python entry point
cli
Team:Execution
labels
Jan 19, 2023
github-actions
bot
changed the title
Turn
[CT-1869] Turn Jan 19, 2023
--output-keys
into MultiOption--output-keys
into MultiOption
29 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Current state
Users can supply
--output-keys
to customize the set of information returned bydbt list
:The type of
--output-keys
is a string. I've always thought the string needed to be a comma-delimited list, but really it could be ... anything? ... so long as the string contains the relevant key name:dbt-core/core/dbt/cli/params.py
Lines 157 to 159 in c85be32
Proposal
We just (#6641) added a
MultiOption
option to support params like--select
, that take multiple space-limited arguments:This would be more consistent, and allow us to treat the type of
output_keys
as a list (right?) for programmatic invocations:Looks like that's even how we've been documenting it (incorrectly)! https://docs.getdbt.com/reference/commands/list
Add a test
We also need an automated test for
dbt list --output json --output-keys
!The text was updated successfully, but these errors were encountered: