Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CT-1921] Improve coverage of previous state test #6753

Closed
gshank opened this issue Jan 26, 2023 · 2 comments
Closed

[CT-1921] Improve coverage of previous state test #6753

gshank opened this issue Jan 26, 2023 · 2 comments
Assignees
@gshank
Labels
repo ci/cd Testing and continuous integration for dbt-core + adapter plugins tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality

Comments

@gshank
Copy link
Contributor

gshank commented Jan 26, 2023

We attempt to test that manifests created in previous versions of dbt Core will work with the current version when doing a state modified selector, in test_previous_version_state.py. The project used for this comparison does not include all varieties of nodes or node-like objects that have changed, including sources. In addition, there should be a test of a disabled version of every node that can be disabled.
@github-actions github-actions bot changed the title Improve coverage of previous state test [CT-1921] Improve coverage of previous state test Jan 26, 2023
@jtcohen6 jtcohen6 added repo ci/cd Testing and continuous integration for dbt-core + adapter plugins tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality Team:Language labels Jan 26, 2023
@jtcohen6
Copy link
Contributor

Thanks for opening @gshank! Agree, this would help us catch bugs like:

@dbeatty10 dbeatty10 mentioned this issue Jan 27, 2023
Closed
2 tasks
@gshank gshank self-assigned this Feb 7, 2023
@jtcohen6 jtcohen6 mentioned this issue Feb 8, 2023
Merged
5 tasks
@gshank gshank mentioned this issue Feb 13, 2023
Merged
6 tasks
@gshank
Copy link
Contributor Author

gshank commented May 17, 2023

This was completed some time ago.

@gshank gshank closed this as completed May 17, 2023
@jtcohen6 jtcohen6 removed the triage label Jun 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gshank gshank

Labels
repo ci/cd Testing and continuous integration for dbt-core + adapter plugins tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gshank @jtcohen6