-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CT-2322] [Feature] Side-by-side diff when an enforced model contract fails #7209
Closed
3 tasks done
Tracked by
#6747
Labels
enhancement
New feature or request
good_first_issue
Straightforward + self-contained changes, good for new contributors!
Comments
dbeatty10
added
enhancement
New feature or request
triage
good_first_issue
Straightforward + self-contained changes, good for new contributors!
and removed
triage
labels
Mar 22, 2023
github-actions
bot
changed the title
[Feature] Side-by-side diff when an enforced model contract fails
[CT-2322] [Feature] Side-by-side diff when an enforced model contract fails
Mar 22, 2023
This change wants to happen here: dbt-core/core/dbt/exceptions.py Lines 2127 to 2141 in a203fe8
This would also require updating a few tests, which currently expect to see some specific text in the logs. It's definitely worth doing for the UX improvement :) |
6 tasks
Created a PR for this with some questions! |
This was referenced Apr 5, 2023
Closed
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
good_first_issue
Straightforward + self-contained changes, good for new contributors!
Is this your first time submitting a feature request?
Describe the feature
See this Loom starting at 12:50 for context of this feature proposal:
https://www.loom.com/share/f436e5e336e4433695dc63d53ee72fcf?t=770
Two things:
Where a preflight check fails for a model contract, could the output look more like this?
Right now, the output looks like this:
snip...
Describe alternatives you've considered
Sometimes the status quo is the way to go ...
... and sometimes it isn't 😉
Who will this benefit?
This will benefit folks that:
Are you interested in contributing this feature?
No response
Anything else?
No response
The text was updated successfully, but these errors were encountered: