[CT-2510] [Bug] Raise an error if non-versioned model is defined with same name as existing versioned model

[jtcohen6]

Set up:

-- models/my_model_v1.sql
select 1 as id

# models/whatever.yml
models:
  - name: my_model
    versions:
      - v: 1

$ dbt parse
12:48:12  Running with dbt=1.5.0
12:48:14  Performance info: target/perf_info.json

Now:

• create models/my_model.sql (no version suffix)
• do not add any new versions to the versions block in the yaml file

Re-parse with partial parsing, and everything looks fine:

$ dbt parse
12:48:29  Running with dbt=1.5.0
12:48:30  Performance info: target/perf_info.json

And now without partial parsing, I see an error (good! I should!):

$ dbt --no-partial-parse parse
12:48:43  Running with dbt=1.5.0
12:48:46  Encountered an error:
Compilation Error
  dbt found two models with the name "my_model".

  Since these resources have the same name, dbt will be unable to find the correct resource
  when looking for ref("my_model").

  To fix this, change the name of one of these resources:
  - model.my_dbt_project.my_model (models/my_model.sql)
  - model.my_dbt_project.my_model.v1 (models/my_model_v1.sql)

[gshank]

This is not a partial parsing bug per se. I've created a test case which does not fail appropriately even with full parsing.

[gshank]

I haven't been able to recreate the compilation error. Whether I create the non-versioned model first or second, it never complains.

[dbeatty10]

I tried the same set of steps as outlined and was not able to produce the compilation error.

[dbeatty10]

I can reproduce this now. I accidentally didn't create and save models/my_model.sql 😅

Here's my key files at the end:

models/_models.yml

models:
  - name: my_model
    versions:
      - v: 1

models/my_model_v1.sql

select 1 as id

models/my_model.sql

select 0 as id

[gshank]

Commit 0de046d yesterday removed the code that was causing the error in the example to be thrown.

[gshank]

The error was thrown in the no-partial-parse case and not in the partial parse case because the order of the nodes encountered was different and the code was checking is_versioned for the previously encountered node.