Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CT-3000] Handle performance/caching issues with using mashumaro jsonschema generation #8426

Closed
gshank opened this issue Aug 16, 2023 · 0 comments · Fixed by #8437
Closed

[CT-3000] Handle performance/caching issues with using mashumaro jsonschema generation #8426

gshank opened this issue Aug 16, 2023 · 0 comments · Fixed by #8437
Assignees
@gshank
Labels
performance tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality

Comments

@gshank
Copy link
Contributor

gshank commented Aug 16, 2023

Description

In #6776, pull request #8132 we switched from using hologram to mashumaro for generating jsonschemas, but the lack of caching caused performance issues (CI jobs took more than twice as long to complete).

Using that work as a base, develop some kind of caching which will match the performance of hologram.
@github-actions github-actions bot changed the title Handle performance/caching issues with using mashumaro jsonschema generation [CT-3000] Handle performance/caching issues with using mashumaro jsonschema generation Aug 16, 2023
@gshank gshank mentioned this issue Aug 16, 2023
Closed
@gshank gshank self-assigned this Aug 16, 2023
@jtcohen6 jtcohen6 added performance tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality labels Aug 16, 2023
@gshank gshank mentioned this issue Aug 16, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gshank gshank

Labels
performance tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Convert to using mashumaro jsonschema with acceptable performance dbt-labs/dbt-core
2 participants
@gshank @jtcohen6