Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Artifacts] Define UnitTestDefinition resource in dbt/artifacts/resources #9667

Closed
1 task done
Tracked by #9099
MichelleArk opened this issue Feb 26, 2024 · 0 comments · Fixed by #9651
Closed
1 task done
Tracked by #9099

[Artifacts] Define UnitTestDefinition resource in dbt/artifacts/resources #9667

MichelleArk opened this issue Feb 26, 2024 · 0 comments · Fixed by #9651
Assignees

Comments

@MichelleArk
Copy link
Contributor

Housekeeping

  • I am a maintainer of dbt-core

Short description

As part of an effort to move any ArtifactMixin subclasses upstream of other core modules into the top -level dbt/artifacts directory, we need to move UnitTestDefinition, which WritableManifest depends on.

Acceptance criteria

UnitTestDefinition (and its necessary dependencies) are moved to a new dbt/artifacts directory. dbt/artifacts should have no additional dependencies on dbt.core except for from contracts.nodes which are actively being refactored.

UnitTestDefinition should be split into data & functional interfaces, defined in dbt/artifacts in dbt/core respectively. Additionally, any inheritance hierarchy between concrete node classes should be flattened as part of this spike.

Should follow initial pattern set in #9379

Suggested Tests

N/A - refactor of existing resource definitions, existing serialization tests should cover us (but this should be confirmed)

Impact to Other Teams

N/A

Will backports be required?

no

Context

No response

@MichelleArk MichelleArk added user docs [docs.getdbt.com] Needs better documentation artifacts labels Feb 26, 2024
@MichelleArk MichelleArk self-assigned this Feb 26, 2024
@MichelleArk MichelleArk removed the user docs [docs.getdbt.com] Needs better documentation label Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant