Replace TestSelector
with ResourceTypeSelector
#10718
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves NA
Problem
The
TestSelector
class was introduced in #2628, but it doesn't need to offer anything differentiated anymore.Solution
Simplify by standardizing upon the
ResourceTypeSelector
.This was accomplished by:
TestSelector
withResourceTypeSelector
TestSelector
classSome history of the
TestSelector
classTo help us avoid a Chesterton's fence situation:
data
andschema
expand_selection
data
andschema
expand_selection
Additional information
Doing this simple refactor makes it easy to see the root cause of the bug report in #10727.
Refactoring first will make it easier to review the code changes in #10706 (which will also resolve #10727).
Checklist