Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add -m flag for tests #1189

Merged
merged 1 commit into from
Dec 14, 2018
Merged

Add -m flag for tests #1189

merged 1 commit into from
Dec 14, 2018

Conversation

clrcrl
Copy link
Contributor

@clrcrl clrcrl commented Dec 13, 2018

Tried to use this flag today but it wasn't there

@drewbanin
Copy link
Contributor

dang, good catch. Merge it when the tests pass

@beckjake
Copy link
Contributor

Great PR!

In general, why are tests not part of the same subcommand list as compile/run? Just because of --non-destructive and --full-refresh? If that's the case, shouldn't docs generate behave like tests?

@drewbanin
Copy link
Contributor

@beckjake yeah - i think test probably belongs in that list more than docs does, right? This is kind of fuzzy, but I think we included the docs subparser in that list because dbt docs generate invokes compilation, and full-refresh/non-destructive mutate the resulting compiled SQL.

Regardless, i think test should get --models, --exclude and --threads from the same place the rest of the subparsers do.

Copy link
Contributor

@drewbanin drewbanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's merge this for grace-kelly and then cleanup main.py more broadly in a future release

:shipit:

@clrcrl clrcrl merged commit afa9fc0 into dev/grace-kelly Dec 14, 2018
@clrcrl clrcrl deleted the add-m-flag-for-tests branch December 14, 2018 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants