Fix for alter table ... rename statements on Snowflake #1324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hmm, looking at the failed unit test, it's possible this never worked correctly? This test has existed for at least 6 months! 99a04e9#diff-25f914e762c6923bab81d1ddd34778cfR93 |
cmcarthur
approved these changes
Feb 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Snowflake,
alter ... renamestatements must include the destination database/schema. Before this change, dbt was just issuing a query like:which resulted in the table being renamed to:
where
prodis the schema specified in the active target. Note that this bug only affects models built into custom schemas.Additionally, added a line of code to correctly render source counts in info level logs during compilation.