-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/archive blocks #1361
Feature/archive blocks #1361
Changes from all commits
53d083e
af8622e
ab63042
be3445b
2b80d7a
d66584f
416cc72
dd23259
1042f1a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,8 @@ | ||
from dbt.adapters.base.meta import available | ||
from dbt.adapters.base.relation import BaseRelation | ||
from dbt.adapters.base.connections import BaseConnectionManager, Credentials | ||
from dbt.adapters.base.impl import BaseAdapter | ||
from dbt.adapters.base.plugin import AdapterPlugin | ||
# these are all just exports, #noqa them so flake8 will be happy | ||
from dbt.adapters.base.meta import available # noqa | ||
from dbt.adapters.base.relation import BaseRelation # noqa | ||
from dbt.adapters.base.relation import Column # noqa | ||
from dbt.adapters.base.connections import BaseConnectionManager # noqa | ||
from dbt.adapters.base.connections import Credentials # noqa | ||
from dbt.adapters.base.impl import BaseAdapter # noqa | ||
from dbt.adapters.base.plugin import AdapterPlugin # noqa |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,3 @@ | ||
import os | ||
|
||
from dbt.config.project import Project | ||
|
||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,3 @@ | ||
from dbt.adapters.sql.connections import SQLConnectionManager | ||
from dbt.adapters.sql.impl import SQLAdapter | ||
# these are all just exports, #noqa them so flake8 will be happy | ||
from dbt.adapters.sql.connections import SQLConnectionManager # noqa | ||
from dbt.adapters.sql.impl import SQLAdapter # noqa |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
import copy | ||
from collections import Mapping | ||
from jsonschema import Draft4Validator | ||
from jsonschema import Draft7Validator | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What's this all about? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I changed this because I wanted to use some features that changed between draft 4 and draft 7 (jsonschema has its own ref mechanism involving schema IDs), but then I reverted those because it got out of hand on the contracts side. I can change it back but I figured it wouldn't hurt to leave it. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Also: It would be cool to annotate our contracts the "proper" jsonschema way. It will be a big PR, but then we could use refs properly. The reason I reverted it was because our current way of combining contracts ( |
||
|
||
from dbt.exceptions import JSONValidationException | ||
from dbt.utils import deep_merge | ||
|
@@ -79,7 +79,7 @@ def validate(self): | |
of this instance. If any attributes are missing or | ||
invalid, raise a ValidationException. | ||
""" | ||
validator = Draft4Validator(self.SCHEMA) | ||
validator = Draft7Validator(self.SCHEMA) | ||
|
||
errors = set() # make errors a set to avoid duplicates | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
|
||
from .renderer import ConfigRenderer | ||
from .profile import Profile, UserConfig, PROFILES_DIR | ||
from .project import Project | ||
from .runtime import RuntimeConfig | ||
# all these are just exports, they need "noqa" so flake8 will not complain. | ||
from .renderer import ConfigRenderer # noqa | ||
from .profile import Profile, UserConfig, PROFILES_DIR # noqa | ||
from .project import Project # noqa | ||
from .runtime import RuntimeConfig # noqa |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think there's any merit to putting this in its own file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it really matters either way.