Fix/report compiled node on error #1381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 29, 2019 08:19
fix macro overrides fix tests that masked the broken macro overrides
cmcarthur
approved these changes
Apr 2, 2019
| @@ -1,5 +1,5 @@ | |||
| {% macro override_me() -%} | |||
| exceptions.raise_compiler_error('this is a bad macro') | |||
| {{ exceptions.raise_compiler_error('this is a bad macro') }} | |||
There was a problem hiding this comment.
yeah, not my finest moment 😬
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1371
If a
RuntimeExceptionhas anodeattribute attached, extract theinjected_sql(if it exists) and theraw_sqlfrom that node and put those values into the error result'sdataattribute with the namescompiled_sqlandraw_sql, respectively - this is the same behavior as the current successful result output.While writing tests for this, I found out that the macro override was broken, and the relevant tests were testing the wrong thing, so I fixed that too.