Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve invalid test warnings/errors (#1325) #1427

Merged
merged 1 commit into from
Apr 30, 2019

Conversation

beckjake
Copy link
Contributor

Fixes #1325

Change the warning/error message for invalid test parameter types to look like this:

$ dbt test
Running with dbt=0.13.0
Compilation warning: Invalid test config given in models/schema.yml:
	test arguments must be dict, got <class 'list'> (value [{'column_name': 'id'}])
Found 4 models, 0 tests, 0 archives, 0 analyses, 172 macros, 4 operations, 0 seed files, 0 sources

The previous output looked like this:

$ dbt test
Running with dbt=0.13.0
in models/schema.yml: test arguments must be dict, got <class 'str'> (value abc)

Copy link
Contributor

@drewbanin drewbanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@beckjake beckjake merged commit f587efd into dev/wilt-chamberlain Apr 30, 2019
@beckjake beckjake deleted the feature/better-schema-test-errors branch April 30, 2019 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write better error message for schema test list indices
2 participants