Only parse docs blocks contents when reading md files (#988) #1513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 6, 2019 09:32
Rename documentation node type to docs so we can filter on it (is this breaking?) Fix block extractor bug with macros/docs that contain quotes Fix block extractor bug with expressions
drewbanin
approved these changes
Jun 6, 2019
| @@ -8,7 +8,7 @@ class NodeType(object): | |||
| Macro = 'macro' | |||
| Operation = 'operation' | |||
| Seed = 'seed' | |||
| Documentation = 'documentation' | |||
| Documentation = 'docs' | |||
There was a problem hiding this comment.
I don't believe that we use this anywhere, nor is it documented. 👍
|
Just uploaded a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #988
Also, related: Fix docs blocks parsing issues
Rename documentation node type to docs so we can filter on it (is this breaking?)
Fix block extractor bug with macros/docs that contain quotes
Fix block extractor bug with expressions