Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the seed path definition #1783

Merged
merged 1 commit into from
Sep 27, 2019

Conversation

beckjake
Copy link
Contributor

@beckjake beckjake commented Sep 26, 2019

Fixes #1723

  • Fix the FilePath definition
  • Add a new attribute to seeds (seed_file_path)
  • Assorted test fixes
    • I may have broken windows tests, we'll see how that pans out
  • Added --no-version-check flag to dbt seed
  • Modified a test to cover the bug

There are no other users of find_matching, and maybe it should just return a FilePath directly, but for now this is fine.

@cla-bot cla-bot bot added the cla:yes label Sep 26, 2019
@beckjake beckjake marked this pull request as ready for review September 26, 2019 18:56
@beckjake beckjake force-pushed the feature/seeds-path-resolution branch 3 times, most recently from a3b3531 to eaa8750 Compare September 27, 2019 15:01
Copy link
Contributor

@drewbanin drewbanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great / works great. Ship it!

Modified a test to cover the bug
Update the FilePath definition
Add a new attribute to seeds (seed_file_path)
Test fixes
Added --no-version-check flag to dbt seed
@beckjake beckjake merged commit 286753b into dev/louisa-may-alcott Sep 27, 2019
@beckjake beckjake deleted the feature/seeds-path-resolution branch September 27, 2019 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"dbt seed" with dependencies -> error in path resolution
2 participants