Fix cancelled ephemeral models (#1993) #2024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During ctrl+c handling, check the name of the canceled connection if it's the name of an ephemeral node, suppress the cancel message
drewbanin
reviewed
Jan 6, 2020
| @@ -242,6 +242,11 @@ def execute_nodes(self): | |||
| raise | |||
|
|
|||
| for conn_name in adapter.cancel_open_connections(): | |||
| if self.manifest is not None: | |||
| node = self.manifest.nodes.get(conn_name) | |||
| if node is not None and node.is_ephemeral_model: | |||
There was a problem hiding this comment.
Are there any node types that won't have an is_ephemeral_model attribute? Like tests/snapshots/run-operations, etc?
Edit: I don't think run-operations go through this code-path in practice, right?
There was a problem hiding this comment.
run-operations can't go through this path. Snapshots have is_ephemeral_model, this code path can only happen for nodes (in particular manifest.nodes.get(conn_name) can only return an Optional[CompileResultNode]) mypy will actually complain if is_ephemeral_model is missing from any type that can end up in node, I'm pretty sure!
drewbanin
approved these changes
Jan 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1993
Suppress messages from cancelling models if the models are ephemeral. Temp connections and connections that aren't models/ephemeral models are still included in the output.