fix --no-compile flag for docs generate #2093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beckjake
force-pushed
the
fix/generate-no-compile
branch
2 times, most recently
from
137e42d
to
483b874
Compare
drewbanin
reviewed
Feb 6, 2020
There was a problem hiding this comment.
Looks great! One super minor request, then approved:
In:
It looks like results can be None if docs generation fails, resulting in an unhandled error:
(env) 21:51:18 ~/fishtown/clients/debug $ dbt docs generate
Running with dbt=0.15.2-a1
Found 1 model, 1 test, 1 snapshot, 2 analyses, 129 macros, 0 operations, 1 seed file, 0 sources
21:53:38 | Concurrency: 8 threads (target='dev')
21:53:38 |
21:53:38 | Done.
21:53:38 | Building catalog
ERROR: Database Error
could not connect to server: Connection refused
Is the server running on host "localhost" (::1) and accepting
TCP/IP connections on port 5433?
could not connect to server: Connection refused
Is the server running on host "localhost" (127.0.0.1) and accepting
TCP/IP connections on port 5433?
Encountered an error:
'NoneType' object has no attribute '_compile_results'
Can we adjust this logic to handle the case where results is None?
beckjake
force-pushed
the
fix/generate-no-compile
branch
from
ffffcde
to
da74681
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2090
I also added a test that
--no-compileruns successfully and generates a catalog, to avoid regressing on this again.