append query comment backport (#2138) #2282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- isinstance check is needed to pass mypy checks
- replaced pr link with issue link
- added ilkinulas to contributers list
- hologram version updated to 0.0.6 to be able to use QueryComment, NoValue and str within the same Union type.
- to disable query comments use : `'query-comment': ''`
|
merging before tests again - another CHANGELOG.md-only merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #2138 but for 0.16.1
Description
This is just me rebasing #2199 onto dev/0.16.1 - I didn't really have to change anything beyond dropping a couple 0.17 commits and updating the changelog.
Checklist
CHANGELOG.mdand added information about my change to the "dbt next" section.