Tests for source overriding (#2264)

CHANGELOG.md

@@ -23,6 +23,9 @@
 - Fix skipped node count in stdout at the end of a run ([#2095](https:/fishtown-analytics/dbt/issues/2095), [#2310](https:/fishtown-analytics/dbt/pull/2310))
 - Fix an issue where BigQuery incorrectly used a relation's quote policy as the basis for the information schema's include policy, instead of the relation's include policy. ([#2188](https:/fishtown-analytics/dbt/issues/2188), [#2325](https:/fishtown-analytics/dbt/pull/2325))
 
+### Under the hood
+- Added more tests for source inheritance ([#2264](https:/fishtown-analytics/dbt/issues/2264), [#2291](https:/fishtown-analytics/dbt/pull/2291))
+
 Contributors:
  - [@raalsky](https:/Raalsky) ([#2224](https:/fishtown-analytics/dbt/pull/2224), [#2228](https:/fishtown-analytics/dbt/pull/2228))
  - [@ilkinulas](https:/ilkinulas) [#2199](https:/fishtown-analytics/dbt/pull/2199)

test/integration/006_simple_dependency_test/local_dependency/models/schema.yml

@@ -0,0 +1,11 @@
+version: 2
+sources:
+ - name: my_source
+ schema: invalid_schema
+ tables:
+ - name: my_table
+sources:
+ - name: seed_source
+ schema: "{{ var('schema_override', target.schema) }}"
+ tables:
+ - name: "seed"

test/integration/006_simple_dependency_test/local_models/dep_source_model.sql

@@ -0,0 +1,2 @@
+{# If our dependency source didn't exist, this would be an errror #}
+select * from {{ source('seed_source', 'seed') }}

test/integration/006_simple_dependency_test/local_models/schema.yml

@@ -0,0 +1,7 @@
+version: 2
+sources:
+ - name: my_source
+ schema: "{{ var('schema_override', target.schema) }}"
+ tables:
+ - name: my_table
+ identifier: seed

test/integration/006_simple_dependency_test/local_models/source_override_model.sql

@@ -0,0 +1,2 @@
+{# If our source override didn't take, this would be an errror #}
+select * from {{ source('my_source', 'my_table') }}

test/integration/006_simple_dependency_test/test_local_dependency.py

@@ -2,6 +2,7 @@
 import os
 import json
 import shutil
+import yaml
 from unittest import mock
 
 import dbt.semver
@@ -56,14 +57,17 @@ def test_postgres_local_dependency(self):
  self.run_dbt(['deps'])
  self.run_dbt(['seed'])
  results = self.run_dbt(['run'])
- self.assertEqual(len(results), 3)
+ self.assertEqual(len(results), 5)
  self.assertEqual({r.node.schema for r in results},
  {self.base_schema(), self.configured_schema()})
- self.assertEqual(
- len([r.node for r in results
- if r.node.schema == self.base_schema()]),
- 2
- )
+
+ base_schema_nodes = [
+ r.node for r in results
+ if r.node.schema == self.base_schema()
+ ]
+ self.assertEqual(len(base_schema_nodes), 4)
+ self.assertTablesEqual('source_override_model', 'seed', self.base_schema(), self.base_schema())
+ self.assertTablesEqual('dep_source_model', 'seed', self.base_schema(), self.base_schema())
 
  @use_profile('postgres')
  def test_postgres_no_dependency_paths(self):
@@ -106,13 +110,24 @@ def test_postgres_missing_dependency(self):
 
 
 class TestSimpleDependencyWithSchema(TestSimpleDependency):
+ def run_dbt(self, cmd, *args, **kwargs):
+ # we can't add this to the config because Sources don't respect dbt_project.yml
+ vars_arg = yaml.safe_dump({
+ 'schema_override': self.base_schema(),
+ })
+ cmd.extend(['--vars', vars_arg])
+ return super().run_dbt(cmd, *args, **kwargs)
+
  @property
  def project_config(self):
  return {
  'macro-paths': ['schema_override_macros'],
  'models': {
  'schema': 'dbt_test',
- }
+ },
+ 'seeds': {
+ 'schema': 'dbt_test',
+ },
  }
 
  def base_schema(self):
@@ -142,7 +157,7 @@ def test_postgres_local_dependency_out_of_date_no_check(self, mock_get):
  self.run_dbt(['deps'])
  self.run_dbt(['seed', '--no-version-check'])
  results = self.run_dbt(['run', '--no-version-check'])
- self.assertEqual(len(results), 3)
+ self.assertEqual(len(results), 5)
 
 
 class TestSimpleDependencyHooks(DBTIntegrationTest):