Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track project id for deps events #2429

Merged
merged 2 commits into from
May 12, 2020

Conversation

drewbanin
Copy link
Contributor

@drewbanin drewbanin commented May 11, 2020

resolves #2351

Description

This PR de-anonymizes packages installed from the hubsite with dbt deps. Further, it includes a project id, adapter name, and dbt version in the information tracked for the dbt deps event. This information:

  • Will help us understand how packages are being used
  • Can be used to paint "live" statistics on hub.getdbt.com (eg. weekly installations)
  • Can be used by package maintainers to assess the impact of breaking changes (eg. by database, or by dbt version)

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change to the "dbt next" section.

@cla-bot cla-bot bot added the cla:yes label May 11, 2020
@drewbanin drewbanin force-pushed the fix/track-package-deps-for-hub-site branch from cbdcc30 to b63a271 Compare May 12, 2020 00:48
@drewbanin drewbanin requested a review from beckjake May 12, 2020 01:45
Copy link
Contributor

@beckjake beckjake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! We should probably fix those variables instead of suppressing the error, but that's a job for another day.

@drewbanin drewbanin merged commit 71e7b0a into dev/octavius-catto May 12, 2020
@drewbanin drewbanin deleted the fix/track-package-deps-for-hub-site branch May 12, 2020 13:32
# Hub packages do not need to be hashed, as they are public
# Use the string 'local' for local package versions
if source_type == 'local':
version = 'local'
Copy link
Contributor

@clrcrl clrcrl Jun 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
version = 'local'
package_name = dbt.utils.md5(package_name)
version = 'local'

@clrcrl clrcrl mentioned this pull request Jun 29, 2020
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Track project ID as part of package install event
3 participants