More windows path lengths

CHANGELOG.md

@@ -3,6 +3,7 @@
 
 ### Fixes
 - dbt config-version: 2 now properly defers rendering `+pre-hook` and `+post-hook` fields. ([#2583](https:/fishtown-analytics/dbt/issues/2583), [#2854](https:/fishtown-analytics/dbt/pull/2854))
+- dbt handles too-long paths on windows that do not report that the path is too long ([#2591](https:/fishtown-analytics/dbt/pull/2591))
 
 
 ## dbt 0.17.1rc1 (June 19, 2020)

core/dbt/clients/system.py

@@ -138,13 +138,20 @@ def write_file(path: str, contents: str = '') -> bool:
  except FileNotFoundError as exc:
  if (
  os.name == 'nt' and
- getattr(exc, 'winerror', 0) == 3 and
  len(path) >= 260
  ):
+ # sometimes we get a winerror of 3 which means the path was
+ # definitely too long, but other times we don't and it means the
+ # path was just probably too long. This is probably based on the
+ # windows/python version.
+ if getattr(exc, 'winerror', 0) == 3:
+ reason = 'Path was too long'
+ else:
+ reason = 'Path was possibly too long'
  # all our hard work and the path was still too long. Log and
  # continue.
  logger.debug(
- f'Could not write to path {path}: Path was too long '
+ f'Could not write to path {path}: {reason} '
  f'({len(path)} characters)'
  )
  else: