Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumped boto3 version uppper range for dbt-redshift #2963

Merged
merged 2 commits into from
Dec 17, 2020

Conversation

tyang209
Copy link
Contributor

resolves #2931

Description

The new Pip dependency resolver as of version 20.3 causes mismatched dependencies to raise an error when installing requirements. This should alleviate some issues by raising the upper range of what is allowed for boto3 to 1.16 which matches what python-snowflake-connector 2.3.6.

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change to the "dbt next" section.

Additional notes.

It looks like the snowflake-connector also removed botocore dependency as of 2.2.6 Link

I thought about removing it from dbt-redshift also but figured I should ask.

I am not 100% sure about testing requirements. I'm just dipping my toe for the first time in doing OSS contributions! I did run make test-quick locally and it did pass all integration tests but failed RPC tests.

@cla-bot
Copy link

cla-bot bot commented Dec 17, 2020

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: tyang209backstage.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https:/settings/emails

Copy link
Contributor

@jtcohen6 jtcohen6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, @tyang209! Could you add yourself as a contributor? :)

@tyang209
Copy link
Contributor Author

Looks great, @tyang209! Could you add yourself as a contributor? :)

Done!

@jtcohen6 jtcohen6 merged commit d23d4b0 into dbt-labs:dev/kiyoshi-kuromiya Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dbt-redshift pins an old version of boto3/botocore
2 participants