Bump snowflake-connector-python[secure-local-storage] from 2.3.6 to 2.4.1 in /plugins/snowflake #3148
Conversation
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps [snowflake-connector-python[secure-local-storage]](https:/snowflakedb/snowflake-connector-python) from 2.3.6 to 2.4.1. - [Release notes](https:/snowflakedb/snowflake-connector-python/releases) - [Commits](snowflakedb/snowflake-connector-python@v2.3.6...v2.4.1) Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
added
dependencies
kwigley
force-pushed
the
dependabot/pip/plugins/snowflake/snowflake-connector-python-secure-local-storage--2.4.1
branch
from
9f00292
to
8680b81
Compare
kwigley
force-pushed
the
dependabot/pip/plugins/snowflake/snowflake-connector-python-secure-local-storage--2.4.1
branch
from
8680b81
to
fefaf7b
Compare
|
after this is merged, we should turn on python 3.9 unit testing |
| 'azure-storage-blob>=12.0.0,<13.0.0', | ||
| 'urllib3>=1.20,<1.26.0', | ||
| # this seems sufficiently broad | ||
| 'snowflake-connector-python[secure-local-storage]~=2.4.1', |
There was a problem hiding this comment.
How bad of an idea is this?
This is the equivalent to >=2.4.1, ==2.4.* (https://www.python.org/dev/peps/pep-0440/#compatible-release)
There was a problem hiding this comment.
Just for my clarity: This is effectively the same as >=2.4.1, <2.5.0, right?
I'm in favor of giving it a go. The SCP folks seem like they've gotten their act together, and the connector is in much better order than it was just a few months ago. Let's do this now, and keep a close eye on SCP releases between now and v0.20.0 final release :)
There was a problem hiding this comment.
Yep! Cool, my thinking exactly 👍
| 'azure-common<2.0.0', | ||
| 'azure-storage-blob>=12.0.0,<13.0.0', |
There was a problem hiding this comment.
I don't think these are needed. We don't directly use these packages in the codebase to my knowledge and the same constraints exist in snowflake-connector-python
https:/snowflakedb/snowflake-connector-python/blob/77ad07f9a07991719258d6b6c6ebfb48691e51de/setup.py#L197-L198
There was a problem hiding this comment.
Looks like we initially pinned these back in Nov 2019 (#1878), when we started being much stricter with SCP
I agree, we don't need them, and we wouldn't want to have them if we're loosening SCP from a tight pin
kwigley
requested review from
jtcohen6,
a team and
gshank
and removed request for
a team
kwigley
deleted the
dependabot/pip/plugins/snowflake/snowflake-connector-python-secure-local-storage--2.4.1
branch
Bumps snowflake-connector-python[secure-local-storage] from 2.3.6 to 2.4.1.
Commits
77ad07fSnow 295621 python connector version bump (#643) (#644)159064eSNOW-294263 logging update (#642)c546c56SNOW-294266 make connection object exit autocommit aware (#641)2dc8f4aSNOW-294004: Bumped up PythonConnector MINOR version from 2.3.10 to 2.4.0 (#6...dee5734SNOW-270946: added percentage unit test to skip old driver (#640)74da1c5SNOW-270946 Progress percentage computation to handle the case when file size...23d8207Add pytest-xdist dependency and -n auto option (#637)1d9f513SNOW-136583 add a test for threshold number parsing (#636)fbf519eSNOW-281305 implement bulk array binding (#633)2b41eaaSNOW-136583 adding multipart PUT threshold support (#627)You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)