Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature to add _n alias to same column names #3147 #3158

Merged
merged 3 commits into from
Mar 17, 2021
Merged

Feature to add _n alias to same column names #3147 #3158

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5f8235f
Feature to add _n alias to same column names #3147
Mar 11, 2021
429dcc7
Update changelog
techytushar Mar 11, 2021
564fe62
Add unit tests for SQL process_results
techytushar Mar 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
- Fix variable `_dbt_max_partition` declaration and initialization for BigQuery incremental models ([#2940](https:/fishtown-analytics/dbt/issues/2940), [#2976](https:/fishtown-analytics/dbt/pull/2976))
- Moving from 'master' to 'HEAD' default branch in git ([#3057](https:/fishtown-analytics/dbt/issues/3057), [#3104](https:/fishtown-analytics/dbt/issues/3104), [#3117](https:/fishtown-analytics/dbt/issues/3117)))
- Requirement on `dataclasses` is relaxed to be between `>=0.6,<0.9` allowing dbt to cohabit with other libraries which required higher versions. ([#3150](https:/fishtown-analytics/dbt/issues/3150), [#3151](https:/fishtown-analytics/dbt/pull/3151))
- Add feature to add `_n` alias to same column names in SQL query ([#3147](https:/fishtown-analytics/dbt/issues/3150), [#3158](https:/fishtown-analytics/dbt/issues/3158))

### Features
- Add optional configs for `require_partition_filter` and `partition_expiration_days` in BigQuery ([#1843](https:/fishtown-analytics/dbt/issues/1843), [#2928](https:/fishtown-analytics/dbt/pull/2928))
Expand Down
9 changes: 8 additions & 1 deletion core/dbt/adapters/sql/connections.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,14 @@ def process_results(
column_names: Iterable[str],
rows: Iterable[Any]
) -> List[Dict[str, Any]]:

unique_column_names = dict()
for idx in range(len(column_names)):
col_name = column_names[idx]
if col_name in unique_column_names:
unique_column_names[col_name] += 1
column_names[idx] = f'{col_name}_{unique_column_names[col_name]}'
else:
unique_column_names[column_names[idx]] = 1
return [dict(zip(column_names, row)) for row in rows]

@classmethod
Expand Down