add unit test and move default logic to mashumaro hook #3305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwigley
requested review from
a team,
nathaniel-may,
iknox-fa,
gshank and
jtcohen6
and removed request for
a team
kwigley
force-pushed
the
fix/bigquery-no-project
branch
from
2f06367
to
4abcd18
Compare
jtcohen6
approved these changes
Apr 28, 2021
gshank
approved these changes
Apr 28, 2021
kwigley
force-pushed
the
fix/bigquery-no-project
branch
from
872c7b3
to
2925f98
Compare
nathaniel-may
approved these changes
Apr 28, 2021
|
@kwigley I see this merged into |
|
@jtcohen6 for sure! I assumed I'd be able to merge |
kwigley
pushed a commit
that referenced
this pull request
Apr 28, 2021
add unit test and move default logic to mashumaro hook
kwigley
pushed a commit
that referenced
this pull request
Apr 28, 2021
add unit test and move default logic to mashumaro hook
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #3218
Description
Adds a test for defaulting BigQuery project/database name. Fixed regression by moving default logic in new object serialization hooks.
Checklist
CHANGELOG.mdand added information about my change to the "dbt next" section.