Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #3598
Description
I saw that the
BuildTask
was inheriting fromCompileTask
, which sets:https:/dbt-labs/dbt/blob/9f716b31b3e0ca57a3722809f8c3405a7b5752f8/core/dbt/task/compile.py#L36-L38
That's the cause of the weird behavior I was seeing when reviewing #3490. We could just override that method for the BuildTask, but what I think we really want is for
dbt build
to operate at parity withdbt run
, and take all of its cues—including how it handles hooks, deferral, etc, etc. I confirmed thatTestTask
,SeedTask
,SnapshotTask
also inherit fromRunTask
, so it feels appropriate thatBuildTask
would as well. Let me know if I'm totally off base here.Tiny thing: I confirmed that a failed model will be handled and downstream resources will be skipped. Now that tests can be skipped, in addition to models/snapshots, I figured we should tweak the
SKIP
log message to be more inclusive of tests.Checklist
CHANGELOG.md
and added information about my change to the "dbt next" section.