Fix logging for default selector #3892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwigley
approved these changes
Sep 17, 2021
iknox-fa
pushed a commit
that referenced
this pull request
Feb 8, 2022
* Fix logging for default selector * Fix flake8, mypy automatic commit by git-black, original commits: 76c59a5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-on to #3875, the actual functionality of which I was eager to get into v0.21 :)
In particular, this fixes #3875 (comment). Only log "Using default selector" when the default selector is in fact being used, not every time one has been defined.
While we're here: Acknowledging that the
get_selection_specmethod is now 99% the same across the three tasks that implement it, move the method definition up toGraphRunnableTask(replacing the abstract method), and remove the duplicated code from the child tasks.CHANGELOG.mdand added information about my change to the "dbt next" section.