[#4006] replace logger.warning with warn_or_error

[laxjesse]

resolves #4006

Description

Uses warn_or_error to log or raise errors depending on arguments passed.

It wasn't 100% clear to me if there should be a test for this or not but I'm happy to add if there should be.

Checklist

• I have signed the CLA
• I have run this code in development and it appears to resolve the stated issue
• This PR includes tests, or tests are not required/relevant for this PR
• I have updated the CHANGELOG.md and added information about my change to the "dbt next" section.

[cla-bot]

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, don't hesitate to ping @drewbanin.

CLA has not been signed by users: @laxjesse

[laxjesse]

I have updated the CHANGELOG.md and added information about my change to the "dbt next" section.

I'm not totally sure where (or if I even should!) be adding info in CHANGELOG.md, so a bit of clarification would be appreciated 🙂

I have signed the CLA

checking with my company to make sure they won't yell at me for signing this

[jtcohen6]

@laxjesse You can add a changelog entry under 1.0.0, in the Fixes section, and add yourself to the list of Contributors below that :)

As soon as you can sign the CLA, I can give this PR a review! Looking good from a first glance.

[laxjesse]

integration-postgres run-test: commands[1] | /home/runner/work/dbt/dbt/.tox/integration-postgres/bin/python -m pytest --profile=postgres test/rpc
ERROR: usage: __main__.py [options] [file_or_dir] [file_or_dir] [...]
__main__.py: error: unrecognized arguments: --profile=postgres
  inifile: /home/runner/work/dbt/dbt/tox.ini
  rootdir: /home/runner/work/dbt/dbt

ERROR: InvocationError for command /home/runner/work/dbt/dbt/.tox/integration-postgres/bin/python -m pytest --profile=postgres test/rpc (exited with code 4)
___________________________________ summary ____________________________________
ERROR:   integration-postgres: commands failed
Error: Process completed with exit code 1.

I might be wrong but I don't believe that this error is related to this change?

[jtcohen6]

@laxjesse You're right, that's an unrelated error related to some dbt-rpc code we're in the process of moving around. It looks like all the actual tests passed, so we can safely ignore that error message for the time being.

This change LGTM! Thanks for the contribution :)