[#4069] Use more standard disabled lookup functions #4073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gshank
force-pushed
the
4069_disabled_partial_parsing
branch
from
0a68a7c
to
65dc76c
Compare
nathaniel-may
approved these changes
Oct 15, 2021
|
This is for 1.0.0. The backport to 0.21.latest already used the DisabledLookup class, but didn't include some of the extra cleanup for consistency. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #4069
Description
Fixes for handling partial parsing and disabled nodes that were backported to 0.21 required a different approach since we wanted to avoid changing the manifest schema. In that fix a new DisabledLookup replaced the existing find_disabled_by_name. The DisabledNameSearcher is a variant of the various *Lookup classes. For consistency and performance we want to use similar functionality for all of these lookups. The previous 'find_disabled_by_name' looped through the entire disabled list/dictionary each time, and having a persistent lookup index on disabled is more efficient.
Checklist
CHANGELOG.mdand added information about my change