New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

assertRaisesRegexp => assertRaisesRegex #4136

Merged

jtcohen6 merged 3 commits into dbt-labs:main from frankcash:frankcash/4132

Oct 27, 2021

Contributor

frankcash commented Oct 26, 2021 •

edited

Loading

Description

Changes assertRaisesRegexp to assertRaisesRegex

Checklist

I have signed the CLA
I have run this code in development and it appears to resolve the stated issue
This PR includes tests, or tests are not required/relevant for this PR
I have updated the CHANGELOG.md and added information about my change

After running the integration tests:


assertRaisesRegexp => assertRaisesRegex

cb98ff2

cla-bot bot added the cla:yes label

Contributor Author

frankcash commented Oct 26, 2021

@jtcohen6 how should I move forward with this

jtcohen6 added the ok_to_test label

Contributor

jtcohen6 commented Oct 27, 2021

@frankcash This looks great, thank you for the quick contribution :)

Could you add yourself to the topmost Contributors list in CHANGELOG.md?

frankcash added 2 commits

October 27, 2021 06:58


Update CHANGELOG.md

4716e0f


Update CHANGELOG.md

f663af7

Contributor Author

frankcash commented Oct 27, 2021

jtcohen6 approved these changes

View reviewed changes

jtcohen6 merged commit 5e46694 into dbt-labs:main

Contributor Author

frankcash commented Oct 27, 2021 via email

Thanks for merging! I was working on squashing the change log commits, but nbd 😎

On Wed, Oct 27, 2021 at 7:06 AM Jeremy Cohen ***@***.***> wrote: Merged #4136 <#4136> into main. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#4136 (comment)>, or unsubscribe <https:/notifications/unsubscribe-auth/ABN32RZK4S6GHSPAW77U27TUI7TJBANCNFSM5GYMC4XA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

-- Charles Frank Cash FOSS Programmer ***@***.*** https:/frankcash https://keybase.io/frankcash <https:/frankcash>

jtcohen6 mentioned this pull request

[Bug] Deprecated unittest aliases were removed in Python 3.11 #4132

Closed

1 task

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment