call sites in core/dbt (excluding main.py) #4202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathaniel-may
suggested changes
Nov 4, 2021
core/dbt/exceptions.py
Outdated
| if log_fmt is not None: | ||
| msg = log_fmt.format(msg) | ||
| logger.warning(msg) | ||
| fire_event(GeneralWarning(msg=str(exc), log_fmt=log_fmt)) |
There was a problem hiding this comment.
I'd like to pass the actual value here instead of its string rep if we can.
There was a problem hiding this comment.
This was passing in the string form to prevent circular imports. Had to move pluralize into the new format.py and fix all imports of pluralize from utils.py to point to format.py. While all the imports are not in /events, they are all for purposes of logging.
There was a problem hiding this comment.
oh nice. Yeah if it's a big pain in the butt to not pass strings, it's not a hill I'll die on, but it looks like you got it work.
emmyoop
force-pushed
the
er/sl-core-dbt
branch
from
1a3f572
to
28d34d9
Compare
nathaniel-may
approved these changes
Nov 4, 2021
emmyoop
added a commit
that referenced
this pull request
Nov 8, 2021
* add struct logging to compilation * add struct logging to tracking * add struct logging to utils * add struct logging to exceptions * fixed some misc errors * updated to send raw ex, removed resulting circ dep
emmyoop
added a commit
that referenced
this pull request
Nov 8, 2021
* add struct logging to compilation * add struct logging to tracking * add struct logging to utils * add struct logging to exceptions * fixed some misc errors * updated to send raw ex, removed resulting circ dep
kwigley
pushed a commit
that referenced
this pull request
Nov 9, 2021
* add struct logging to compilation * add struct logging to tracking * add struct logging to utils * add struct logging to exceptions * fixed some misc errors * updated to send raw ex, removed resulting circ dep
nathaniel-may
pushed a commit
that referenced
this pull request
Nov 9, 2021
* add struct logging to compilation * add struct logging to tracking * add struct logging to utils * add struct logging to exceptions * fixed some misc errors * updated to send raw ex, removed resulting circ dep
iknox-fa
pushed a commit
that referenced
this pull request
Feb 8, 2022
* add struct logging to compilation * add struct logging to tracking * add struct logging to utils * add struct logging to exceptions * fixed some misc errors * updated to send raw ex, removed resulting circ dep automatic commit by git-black, original commits: d8b97c1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Modifying call sites for structured logging in core/dbt/deps excluding core/dbt/deps/main.py & logger.py
Checklist
CHANGELOG.mdand added information about my change