Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds additional augmented assignment statements (#4315) #4331

Merged
merged 3 commits into from
Nov 27, 2021

Conversation

sarah-weatherbee
Copy link
Contributor

@sarah-weatherbee sarah-weatherbee commented Nov 24, 2021

Resolves issue #4315 by adding augmented assignment statements to:
core/dbt/dataclass_schema.py
core/dbt/graph/selector_spec.py
core/dbt/parser/manifest.py
test/integration/047_dbt_ls_test/test_ls.py
test/unit/test_macro_calls.py

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change

@cla-bot
Copy link

cla-bot bot commented Nov 24, 2021

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, don't hesitate to ping @drewbanin.

CLA has not been signed by users: @sarah-weatherbee

@emmyoop
Copy link
Member

emmyoop commented Nov 24, 2021

@cla-bot check

@cla-bot
Copy link

cla-bot bot commented Nov 24, 2021

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, don't hesitate to ping @drewbanin.

CLA has not been signed by users: @sarah-weatherbee

@cla-bot
Copy link

cla-bot bot commented Nov 24, 2021

The cla-bot has been summoned, and re-checked this pull request!

@emmyoop
Copy link
Member

emmyoop commented Nov 24, 2021

Once you get the CLA signed, you'll also want to add a line to the CHANGELOG.md for your change as well as add yourself to the contributors list. Looks like you'll be the first contributor for the next release so you can add that section!

@cla-bot cla-bot bot added the cla:yes label Nov 27, 2021
@emmyoop emmyoop self-requested a review November 27, 2021 15:02
Copy link
Member

@emmyoop emmyoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for helping make dbt-core better! Excited to work with you on more contributions!

@emmyoop emmyoop merged commit d80646c into dbt-labs:main Nov 27, 2021
iknox-fa pushed a commit that referenced this pull request Feb 8, 2022
* adds additional augmented assignment statements (#4315)

* Per PR comments, revised CHANGELOG.md to note change and contributor info

automatic commit by git-black, original commits:
  d80646c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants