Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve checking of schema version for pre-1.0.0 manifests #4497

Merged
merged 2 commits into from
Dec 16, 2021
Merged

Improve checking of schema version for pre-1.0.0 manifests #4497

merged 2 commits into from
Dec 16, 2021

Conversation

gshank
Copy link
Contributor

@gshank gshank commented Dec 15, 2021

resolves #4470

Description

When loading 'state' from previous manifests and run results, check that the schema version of the artifacts matches the current schema version.

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change

@cla-bot cla-bot bot added the cla:yes label Dec 15, 2021
@gshank gshank force-pushed the pre_1.0.0_manifest branch 2 times, most recently from d4672b0 to 6616e02 Compare December 16, 2021 14:37
@gshank gshank requested a review from emmyoop December 16, 2021 16:43
emmyoop
emmyoop approved these changes Dec 16, 2021
View reviewed changes
Copy link
Member

@emmyoop emmyoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gshank gshank merged commit 067b861 into main Dec 16, 2021
@gshank gshank deleted the pre_1.0.0_manifest branch December 16, 2021 18:30
gshank added a commit that referenced this pull request Dec 16, 2021
@gshank
[#4470 BACKPORT] Improve checking of schema version for pre-1.0.0 man…
239e968 
…ifests (#4497)
gshank added a commit that referenced this pull request Dec 16, 2021
@gshank
[#4470 BACKPORT] Improve checking of schema version for pre-1.0.0 man…
807bfd2 
…ifests (#4497)
gshank added a commit that referenced this pull request Dec 17, 2021
@gshank
[#4470 BACKPORT] Improve checking of schema version for pre-1.0.0 man…
406bdcc 
…ifests (#4497) (#4503)
iknox-fa pushed a commit that referenced this pull request Feb 8, 2022
@gshank @iknox-fa
Improve checking of schema version for pre-1.0.0 manifests (#4497)
251a88c 
* [#4470] Improve checking of schema version for pre-1.0.0 manifests

* Check exception code instead of message in test

automatic commit by git-black, original commits:
  067b861
  8379edc
iknox-fa pushed a commit that referenced this pull request Feb 8, 2022
@gshank @iknox-fa
Improve checking of schema version for pre-1.0.0 manifests (#4497)
4bd0687 
* [#4470] Improve checking of schema version for pre-1.0.0 manifests

* Check exception code instead of message in test

automatic commit by git-black, original commits:
  067b861
@jtcohen6 jtcohen6 mentioned this pull request Mar 26, 2022
Merged
4 tasks
@aranke aranke mentioned this pull request May 20, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emmyoop emmyoop emmyoop approved these changes

@jtcohen6 jtcohen6 Awaiting requested review from jtcohen6

@kwigley kwigley Awaiting requested review from kwigley

Assignees
No one assigned
Labels
cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CORE-20] [Bug] Jobs running on dbt 1.0.0 are failing when setup to defer to a pre 1.0.0 manifest
2 participants
@gshank @emmyoop